fix path of sync run log file #7661
Conversation
kaikli
force-pushed
the
fix-7654-ugly
branch
from
4bc73dc to
5da159e
Compare
Signed-off-by: kaikli <[email protected]>
kaikli
force-pushed
the
fix-7654-ugly
branch
from
5da159e to
27adf1e
Compare
| const QString logpath = | ||
| !Utility::isWindows() | ||
| ? QStandardPaths::writableLocation(QStandardPaths::AppConfigLocation) | ||
| : QStandardPaths::writableLocation(QStandardPaths::AppDataLocation); |
There was a problem hiding this comment.
why do we need to special case windows ?
There was a problem hiding this comment.
Because of the way how the configPath is generated in src/libsync/configfile.cpp#L366 and Windows stores everything to the data location instead of the config location.
This solves the problem that the migration tries to move the config directory from $XDG_DATA_DIR to $XDG_CONFIG_DIR and then writes the sync run logs to the data location again. This throws a log warning for each application startup.
But I think we can also use ConfigFile::logPath() from src/libsync/configfile.cpp#L1114 instead.
But I would still prefer to use the second PR #7665 to solve this problem, because log files should not be written to a config location.
There was a problem hiding this comment.
@kaikli I was away for some time
I will try to look again at this soon.
I am not sure about the move for log files as many users might find themselves lost when their log files move to another folder. I understand that some people have a strong opinion on the location of file but I am not sure if the impact on users will be positive overall.
This should fix the issue #7654 where the old log location is used after moving the files to the new location on linux.
I have tested it locally and it seems to solve the problem, but I'm not really sure why the log should be stored in the config directory at all. If we want to solve this, we need to exclude the log files from the migration in src/gui/application.cpp:L549 and move the other log files in $XDG_CONFIG_DIR/Nextcloud/logs to the data directory.
Thats the reason why I have also created a second pull request #7665 with a consistent log directory. Please choose one of them.