Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable legacy import dialog #7623

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Disable legacy import dialog #7623

merged 3 commits into from
Dec 9, 2024

Conversation

camilasan
Copy link
Member

No description provided.

mgallien
mgallien requested changes Dec 9, 2024
View reviewed changes
NEXTCLOUD.cmake Outdated Show resolved Hide resolved
src/libsync/theme.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the feature/disable-import-dialog branch 3 times, most recently from 2d1c27a to 22dd38a Compare December 9, 2024 11:22
mgallien
mgallien requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

final comment
should make it reliable and ensure we understand what happen

src/libsync/theme.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the feature/disable-import-dialog branch from 22dd38a to e4fd4ca Compare December 9, 2024 12:23
mgallien
mgallien requested changes Dec 9, 2024
View reviewed changes
src/libsync/theme.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the feature/disable-import-dialog branch from e4fd4ca to 0b39956 Compare December 9, 2024 13:04
mgallien
mgallien requested changes Dec 9, 2024
View reviewed changes
NEXTCLOUD.cmake Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the feature/disable-import-dialog branch from d9f1850 to 1732acd Compare December 9, 2024 14:05
@mgallien mgallien force-pushed the feature/disable-import-dialog branch from 1732acd to 5456ed1 Compare December 9, 2024 15:42
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7623-5456ed107ac7d3e3369f2c5f9404554ebf1341ed-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
27 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit f538cad into master Dec 9, 2024
13 of 16 checks passed
@mgallien mgallien deleted the feature/disable-import-dialog branch December 9, 2024 17:01
@mgallien
Copy link
Collaborator

mgallien commented Dec 9, 2024

/backport to stable-3.15

@backportbot backportbot bot mentioned this pull request Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @mgallien