Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Remove content margins account settings subsections #7568

Merged

Conversation

claucambra
Copy link
Collaborator

After:

Screen.Recording.2024-11-26.at.14.40.06.mov

Before:

Screen.Recording.2024-11-26.at.14.49.27.mov

@claucambra claucambra added this to the 3.15.1 milestone Nov 26, 2024
@claucambra claucambra self-assigned this Nov 26, 2024
@Rello
Copy link
Contributor

Rello commented Nov 26, 2024

@claucambra wasn´t before better - just the first tab also needed margins?

now right/left is gone, but the top one is there anyway. so to have the same around looks more consistent

@claucambra
Copy link
Collaborator Author

@claucambra wasn´t before better - just the first tab also needed margins?

I'm not sure I agree, I think the margin adds unnecessary whitespace and makes it look a bit strange and inset

now right/left is gone, but the top one is there anyway. so to have the same around looks more consistent

The top margin only exists due to the style of the tab selector on macOS (where the buttons are half-in half-out of the container). On other platforms there will be no margin. Due to the unique design of this I am not sure how we can address it specifically on mac

@claucambra
Copy link
Collaborator Author

/backport to stable-3.15

@Rello
Copy link
Contributor

Rello commented Nov 27, 2024

@claucambra what about making the first ones also with a grey background like the third tab?
this would at least not make them look so hard

@claucambra claucambra changed the title Bugfix/remove content margins account settings subsections gui: Remove content margins account settings subsections Nov 28, 2024
@mgallien mgallien force-pushed the bugfix/remove-content-margins-account-settings-tablayout branch from ec39d10 to 648dd82 Compare December 9, 2024 10:12
@mgallien mgallien force-pushed the bugfix/remove-content-margins-account-settings-tablayout branch from 648dd82 to 65ab4b3 Compare December 9, 2024 12:33
@mgallien mgallien enabled auto-merge December 9, 2024 12:33
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7568-65ab4b3f1f40dd7d076a2f7c540e3d757a0bd1ac-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarqubecloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
9 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 65c1407 into master Dec 9, 2024
13 of 16 checks passed
@mgallien mgallien deleted the bugfix/remove-content-margins-account-settings-tablayout branch December 9, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants