-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gui: Remove content margins account settings subsections #7568
gui: Remove content margins account settings subsections #7568
Conversation
@claucambra wasn´t before better - just the first tab also needed margins? now right/left is gone, but the top one is there anyway. so to have the same around looks more consistent |
I'm not sure I agree, I think the margin adds unnecessary whitespace and makes it look a bit strange and inset
The top margin only exists due to the style of the tab selector on macOS (where the buttons are half-in half-out of the container). On other platforms there will be no margin. Due to the unique design of this I am not sure how we can address it specifically on mac |
/backport to stable-3.15 |
@claucambra what about making the first ones also with a grey background like the third tab? |
ec39d10
to
648dd82
Compare
… tree for vfs and connection settings Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
648dd82
to
65ab4b3
Compare
AppImage file: nextcloud-PR-7568-65ab4b3f1f40dd7d076a2f7c540e3d757a0bd1ac-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
After:
Screen.Recording.2024-11-26.at.14.40.06.mov
Before:
Screen.Recording.2024-11-26.at.14.49.27.mov