Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of sharemodel.cpp on MSVC #5912

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra self-assigned this Jul 21, 2023
@claucambra claucambra force-pushed the bugfix/fix-msvc-sharemodel-build branch from f742401 to 630648b Compare July 21, 2023 10:42
@claucambra claucambra force-pushed the bugfix/fix-msvc-sharemodel-build branch from 630648b to 71adc20 Compare July 21, 2023 10:44
@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #5912 (71adc20) into master (bb87813) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5912      +/-   ##
==========================================
+ Coverage   60.05%   60.08%   +0.03%     
==========================================
  Files         145      145              
  Lines       18759    18762       +3     
==========================================
+ Hits        11265    11274       +9     
+ Misses       7494     7488       -6     
Impacted Files Coverage Δ
src/common/filesystembase.cpp 75.00% <0.00%> (-1.44%) ⬇️

... and 3 files with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5912-71adc2086b0e2633ba4db30fc3e32309aef1f14b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit f8b8d44 into master Jul 21, 2023
@allexzander allexzander deleted the bugfix/fix-msvc-sharemodel-build branch July 21, 2023 12:03
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants