[stable-3.9] Set VFS PinState to Excluded for ignored files. #5904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items. If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case. As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon. Closes #5524 Closes #5594 Co-authored-by: Matthieu Gallien <[email protected]> Signed-off-by: Dries Mys <[email protected]>
F.ex. Folder::slotWatchedPathChanged calls this function on non- placeholder files to check if the ignored file is already assigned an Excluded pin state. Note that it is allowed to set the pin state to Excluded on non-placeholder files. Signed-off-by: Dries Mys <[email protected]>
Signed-off-by: Dries Mys <[email protected]>
mgallien
approved these changes
Jul 20, 2023
|
SonarCloud Quality Gate failed.
|
|
AppImage file: nextcloud-PR-5904-470a983b474d9f00fa1c880f97c57c38acbc08e0-x86_64.AppImage |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## stable-3.9 #5904 +/- ##
==============================================
+ Coverage 60.31% 60.45% +0.13%
==============================================
Files 145 145
Lines 18640 18650 +10
==============================================
+ Hits 11242 11274 +32
+ Misses 7398 7376 -22
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5853