Fix crash and incorrect implementation of seen chat notifications removal #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
changed the title
allexzander
changed the title
|
/backport to stable-3.9 |
mgallien
requested changes
Jul 11, 2023
There was a problem hiding this comment.
I tested with concurrent access detection tool from valgrind and failed to get any concurrent unprotected access
@allexzander why did you added mutexes ?
allexzander
force-pushed
the
bugfix/fix-incorrect-seen-chat-notifications-removal
branch
from
1a9f4a7 to
50dd564
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5879 +/- ##
==========================================
- Coverage 60.09% 60.06% -0.03%
==========================================
Files 145 145
Lines 18746 18746
==========================================
- Hits 11265 11260 -5
- Misses 7481 7486 +5
|
allexzander
force-pushed
the
bugfix/fix-incorrect-seen-chat-notifications-removal
branch
from
c80206c to
db76f74
Compare
|
@allexzander all good for me |
mgallien
force-pushed
the
bugfix/fix-incorrect-seen-chat-notifications-removal
branch
from
db76f74 to
9ba6c02
Compare
mgallien
approved these changes
Jul 17, 2023
… seen chat notifications removal. Improved notifications fetch code to avoid multiple calls from different threads. Signed-off-by: alex-z <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/fix-incorrect-seen-chat-notifications-removal
branch
from
bd1fcb2 to
5991e78
Compare
|
SonarCloud Quality Gate failed.
|
|
AppImage file: nextcloud-PR-5879-5991e780f553d6388a44461944c5783a8327fc52-x86_64.AppImage |
mgallien
deleted the
bugfix/fix-incorrect-seen-chat-notifications-removal
branch
allexzander
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crash in
_finalListremoval loop. Fix incorrect implementation of seen chat notifications removal. Improved notifications fetch code to avoid multiple calls from different threads.