Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/log less verbose #5769

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Bugfix/log less verbose #5769

merged 3 commits into from
Jun 7, 2023

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Jun 6, 2023

No description provided.

@mgallien mgallien force-pushed the bugfix/logLessVerbose branch from 79462ec to 6ee2a6d Compare June 6, 2023 12:52
allexzander
allexzander suggested changes Jun 6, 2023
View reviewed changes
src/libsync/logger.cpp Show resolved Hide resolved
@allexzander allexzander self-requested a review June 6, 2023 13:05
@mgallien mgallien enabled auto-merge June 6, 2023 13:13
@codecov
Copy link

codecov bot commented Jun 6, 2023 •
edited
Loading

Codecov Report

Merging #5769 (f098de6) into master (fe42736) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head f098de6 differs from pull request most recent head 5a86446. Consider uploading reports for the commit 5a86446 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5769      +/-   ##
==========================================
+ Coverage   60.33%   60.38%   +0.05%     
==========================================
  Files         143      143              
  Lines       18518    18518              
==========================================
+ Hits        11173    11183      +10     
+ Misses       7345     7335      -10
Impacted Files Coverage Δ
src/libsync/configfile.cpp 26.32% <0.00%> (ø)
src/libsync/logger.cpp 28.57% <ø> (ø)

... and 3 files with indirect coverage changes

mgallien added 3 commits June 6, 2023 16:32
@mgallien
by default disable debug log level
b28e635 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
rotate log files every 3 MBs
a34bac3 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien
do not log twice in debug mode
5a86446 
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/logLessVerbose branch from f098de6 to 5a86446 Compare June 6, 2023 14:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5769-5a86446f9142159d27ce6135a061a5273e1f3276-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit ec302c8 into master Jun 7, 2023
@mgallien mgallien deleted the bugfix/logLessVerbose branch June 7, 2023 07:32
@mgallien
Copy link
Collaborator Author

mgallien commented Jun 7, 2023

/backport to stable-3.9

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 7, 2023
Merged
@thrimbor thrimbor mentioned this pull request Jun 7, 2023
Closed
@mgallien mgallien added this to the 3.10.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @allexzander @claucambra