Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. Conflict resolution button not clickable. #5766

Merged

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Jun 5, 2023

model property is not the entire activity item model, activityData custom property must be used

@AndyScherzinger AndyScherzinger added this to the 3.9.0 milestone Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #5766 (fd69e6d) into master (ec302c8) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5766      +/-   ##
==========================================
- Coverage   60.36%   60.33%   -0.03%     
==========================================
  Files         143      143              
  Lines       18518    18518              
==========================================
- Hits        11178    11173       -5     
- Misses       7340     7345       +5     

see 2 files with indirect coverage changes

@mgallien mgallien enabled auto-merge June 7, 2023 06:59
@mgallien mgallien force-pushed the bugfix/conflict-resolution-button-in-activity-not-working branch from e369109 to b4b95a6 Compare June 7, 2023 06:59
@mgallien mgallien requested review from a team and camilasan and removed request for a team June 7, 2023 07:11
@tobiasKaminsky
Copy link
Member

/backport to stable-3.9

@mgallien mgallien force-pushed the bugfix/conflict-resolution-button-in-activity-not-working branch from b4b95a6 to fd69e6d Compare June 7, 2023 08:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5766-fd69e6dacab70c63f180d863d06afafecde73bfc-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit d63eb6a into master Jun 7, 2023
@mgallien mgallien deleted the bugfix/conflict-resolution-button-in-activity-not-working branch June 7, 2023 09:47
@RonGee
Copy link

RonGee commented Oct 4, 2023

Not fixed in 3.10.0 though it claims to have been. Button is still not accessible to be clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants