fix build on windows by adding missing archive name properties on libs #5745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the archive output name is used on windows but was never set for 2 libraries with this they will have a proper name matching other components of the shared library Signed-off-by: Matthieu Gallien <[email protected]>
claucambra
approved these changes
May 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5745 +/- ##
==========================================
- Coverage 60.47% 60.36% -0.11%
==========================================
Files 143 143
Lines 18518 18518
==========================================
- Hits 11198 11179 -19
- Misses 7320 7339 +19 |
|
/backport to stable-3.8 |
|
backport to stable-3.9 |
|
AppImage file: nextcloud-PR-5745-47a7a267ea5f9d369fe9d524b4224f92f45471f4-x86_64.AppImage |
|
/backport to stable-3.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the archive output name is used on windows but was never set for 2 libraries
with this they will have a proper name matching other components of the shared library