Fix tray styling

[claucambra]

Addresses the issues caused by #5377

Principally:

• Simplifies code
• Returns two-line activity titles to improve readability
• Fixes clipping of avatars
• Moves file details button to first row to conserve space
• Uses our custom button components for consistency
• Fixes dark mode issues
• Properly aligns activity text when secondary text is not there
• more

After changes:

Screen.Recording.2023-05-19.at.23.24.13.mov

Before changes:

Screen.Recording.2023-05-19.at.18.07.09.mov

[codecov]

Codecov Report

Merging #5715 (0acc015) into master (867fae1) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 0acc015 differs from pull request most recent head 4c096a8. Consider uploading reports for the commit 4c096a8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
+ Coverage   60.26%   60.37%   +0.10%     
==========================================
  Files         143      143              
  Lines       18518    18518              
==========================================
+ Hits        11160    11180      +20     
+ Misses       7358     7338      -20     

see 5 files with indirect coverage changes

[claucambra]

/backport to stable-3.9

[mgallien]

@claucambra can you provide screenshot before/after ?

[claucambra]

@claucambra can you provide screenshot before/after ?

Attached now 🙂

[claucambra]

dark mode issues when fusion is enabled:

[claucambra]

dark mode issues when fusion is enabled:

now fixed

[mgallien]

@claucambra can you solve the conflicts ?

[claucambra]

@claucambra can you solve the conflicts ?

Yep, now fixed

[mgallien]

dark mode works fine !!!! super cool
see my inline comments
including relying on implicit magic behavior of our components inheriting existing ones from Qt modules
given the amount of visual changes, I think you should request a design review on this

[claucambra]

dark mode works fine !!!! super cool

Thanks :)

see my inline comments including relying on implicit magic behavior of our components inheriting existing ones from Qt modules

I am not convinced by the magic behaviour as the purpose of the CustomButton is to abstract broad visual behaviour so as to not have to repeat it everywhere throughout our code -- that is to say, we shouldn't have to implement things like a hover effect everywhere, which relies on hoverEnabled: true already being set in CustomButton

[mgallien]

dark mode works fine !!!! super cool

Thanks :)

see my inline comments including relying on implicit magic behavior of our components inheriting existing ones from Qt modules

I am not convinced by the magic behaviour as the purpose of the CustomButton is to abstract broad visual behaviour so as to not have to repeat it everywhere throughout our code -- that is to say, we shouldn't have to implement things like a hover effect everywhere, which relies on hoverEnabled: true already being set in CustomButton

if what you want to achieve is that by default all instances of CustomButton do have hover effect enabled then you can just set a default value for the property inside CustomButton
if someone wants to use the component it may decide to change the value of the property and currently that would have no effect looking like a bug (and I would consider this a bug)

[claucambra]

dark mode works fine !!!! super cool

Thanks :)

see my inline comments including relying on implicit magic behavior of our components inheriting existing ones from Qt modules

I am not convinced by the magic behaviour as the purpose of the CustomButton is to abstract broad visual behaviour so as to not have to repeat it everywhere throughout our code -- that is to say, we shouldn't have to implement things like a hover effect everywhere, which relies on hoverEnabled: true already being set in CustomButton

if what you want to achieve is that by default all instances of CustomButton do have hover effect enabled then you can just set a default value for the property inside CustomButton if someone wants to use the component it may decide to change the value of the property and currently that would have no effect looking like a bug (and I would consider this a bug)

Okay, I declared it explicitly in CustomButton now

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5715-4c096a885c0c1966c7a12a230c667a8c516068bd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information