Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS build when file provider module build is disabled #5707

Merged
merged 3 commits into from
May 30, 2023
Merged

Fix macOS build when file provider module build is disabled #5707

merged 3 commits into from
May 30, 2023

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023 •
edited
Loading

Codecov Report

Merging #5707 (8659567) into master (867fae1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5707      +/-   ##
==========================================
- Coverage   60.26%   60.26%   -0.01%     
==========================================
  Files         143      143              
  Lines       18518    18518              
==========================================
- Hits        11160    11159       -1     
- Misses       7358     7359       +1

see 1 file with indirect coverage changes

@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

mgallien
mgallien requested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

CMakeLists.txt Outdated Show resolved Hide resolved
@claucambra claucambra requested a review from mgallien May 24, 2023 06:59
mgallien
mgallien requested changes May 25, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@claucambra
Copy link
Collaborator Author

I removed the CMakeLists add_definition call

@claucambra claucambra requested a review from mgallien May 26, 2023 02:03
@mgallien mgallien force-pushed the bugfix/build-mac-without-fp branch from 56606cb to 8659567 Compare May 30, 2023 09:11
@mgallien mgallien enabled auto-merge May 30, 2023 09:11
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5707-8659567352756b31d58269299e0c1d806e3a8ff6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mgallien mgallien merged commit c51b057 into master May 30, 2023
@mgallien mgallien deleted the bugfix/build-mac-without-fp branch May 30, 2023 10:32
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 30, 2023
Merged
@mgallien mgallien added this to the 3.10.0 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@claucambra @nextcloud-desktop-bot @mgallien