Debian build classification 'beta' cannot override 'release'. #5521
Conversation
ivaradi
force-pushed
the
fix-build-classification
branch
from
2f5ba28 to
9f4a6dc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5521 +/- ##
==========================================
- Coverage 59.00% 58.94% -0.07%
==========================================
Files 143 143
Lines 18313 18313
==========================================
- Hits 10805 10794 -11
- Misses 7508 7519 +11 |
|
@claucambra thanks for the approval. Could you, please, also merge it? I think the check failures are unrelated to the patch, but I cannot merge due to them. |
mgallien
force-pushed
the
fix-build-classification
branch
from
9f4a6dc to
0e455bd
Compare
No problem. I think it's a valid use-case to release a final release candidate. |
The Ubuntu/Debian build script classifies the built commit based on the tags, if any, pointing to the commit. This classification is used to determine the target PPA. If no suitable tag points the commit, it will be an 'alpha' build. If a tag of the format 'vA.B.C' points to the commit, it will be a 'release' build, if the version is followed by something, e.g. 'vA.B.C-rc1', it will be a 'beta' build. The current classification fails if both a 'beta' and a 'release' tag points to the commit, such as in case of the recent v3.7.4 release, where the '-rc1' tag points to the commit that was later released. It was deemed to be a 'beta' build. This patch fixes this behaviour to build such commits as 'release'es. Signed-off-by: István Váradi <[email protected]>
mgallien
force-pushed
the
fix-build-classification
branch
from
0e455bd to
5dacf60
Compare
|
AppImage file: nextcloud-PR-5521-5dacf60fae55c96df16f36a0411fed1ce5971d5c-x86_64.AppImage |
The Ubuntu/Debian build script classifies the built commit based on the tags, if any, pointing to the commit. This classification is used to determine the target PPA.
If no suitable tag points the commit, it will be an 'alpha' build. If a tag of the format 'vA.B.C' points to the commit, it will be a 'release' build, if the version is followed by something, e.g. 'vA.B.C-rc1', it will be a 'beta' build.
The current classification fails if both a 'beta' and a 'release' tag points to the commit, such as in case of the recent v3.7.4 release, where the '-rc1' tag points to the commit that was later released. It was deemed to be a 'beta' build. This patch fixes this behaviour to build such commits as 'release'es.