Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of 2FA notification. #5486

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix display of 2FA notification. #5486

merged 1 commit into from
Mar 8, 2023

Conversation

camilasan
Copy link
Member

Fix for issue #5421: add server notifications to the activities list when the user needs to act on it.

2fa

It should also work for other notifications:
sharing

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would an auto test be possible ?

@camilasan
Copy link
Member Author

would an auto test be possible ?

Good point 🙈 I can look into it tomorrow.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #5486 (ec7b548) into master (20e20a6) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5486   +/-   ##
=======================================
  Coverage   58.94%   58.94%           
=======================================
  Files         143      143           
  Lines       18313    18313           
=======================================
+ Hits        10794    10795    +1     
+ Misses       7519     7518    -1     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 73.18% <0.00%> (+0.22%) ⬆️

@camilasan
Copy link
Member Author

/rebase

Fix for issue #5421: add server notifications to the activities list
when the user needs to act on it.

Signed-off-by: Camila <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5486-ec7b5481d45f89bccbe2fc7cb8cd0548452c8729-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit 30cfba4 into master Mar 8, 2023
@mgallien mgallien deleted the bugfix/5421 branch March 8, 2023 12:28
@mgallien
Copy link
Collaborator

mgallien commented Mar 8, 2023

/backport to stable-3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants