Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display 'Search globally' as the last sharees list element #5485

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Display 'Search globally' as the last sharees list element #5485

merged 1 commit into from
Mar 3, 2023

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Feb 28, 2023 •
edited
Loading

this will fix #3847

@allexzander allexzander force-pushed the feature/global-search-sharees branch 2 times, most recently from 6eca13a to e9e27d5 Compare March 1, 2023 13:56
@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Merging #5485 (e9e27d5) into master (355dbd1) will decrease coverage by 0.95%.
The diff coverage is n/a.

❗ Current head e9e27d5 differs from pull request most recent head 31de652. Consider uploading reports for the commit 31de652 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5485      +/-   ##
==========================================
- Coverage   58.87%   57.92%   -0.95%     
==========================================
  Files         143      141       -2     
  Lines       18312    18149     -163     
==========================================
- Hits        10781    10513     -268     
- Misses       7531     7636     +105
Impacted Files Coverage Δ
src/libsync/clientsideencryptionjobs.cpp 9.01% <0.00%> (-34.95%) ⬇️
src/libsync/clientsideencryptionjobs.h 0.00% <0.00%> (-10.00%) ⬇️
src/libsync/clientsideencryption.cpp 26.00% <0.00%> (-8.37%) ⬇️
src/libsync/syncengine.h 60.00% <0.00%> (-5.00%) ⬇️
src/common/syncjournaldb.cpp 77.07% <0.00%> (-1.22%) ⬇️
src/libsync/discoveryphase.cpp 78.83% <0.00%> (-0.24%) ⬇️
src/libsync/account.h 36.84% <0.00%> (ø)
src/libsync/syncfileitem.h 42.37% <0.00%> (ø)
src/libsync/discoveryphase.h 25.00% <0.00%> (ø)
src/libsync/clientsideencryption.h 30.76% <0.00%> (ø)
... and 9 more

@allexzander allexzander force-pushed the feature/global-search-sharees branch 3 times, most recently from 451a2f9 to 86fcbe5 Compare March 1, 2023 16:04
@allexzander allexzander requested a review from camilasan March 1, 2023 16:04
claucambra
claucambra requested changes Mar 1, 2023
View reviewed changes
src/gui/filedetails/ShareeSearchField.qml Outdated Show resolved Hide resolved
src/gui/filedetails/ShareeDelegate.qml Outdated Show resolved Hide resolved
src/gui/filedetails/ShareeDelegate.qml Outdated Show resolved Hide resolved
src/gui/filedetails/ShareeDelegate.qml Outdated Show resolved Hide resolved
src/gui/filedetails/ShareeDelegate.qml Outdated Show resolved Hide resolved
src/gui/filedetails/shareemodel.cpp Outdated Show resolved Hide resolved
src/gui/filedetails/shareemodel.cpp Show resolved Hide resolved
src/gui/filedetails/sharemodel.cpp Outdated Show resolved Hide resolved
src/gui/filedetails/sharemodel.h Outdated Show resolved Hide resolved
src/gui/sharee.h Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from claucambra March 1, 2023 17:48
@allexzander allexzander force-pushed the feature/global-search-sharees branch from 86b369e to 7aa7043 Compare March 3, 2023 16:59
@allexzander allexzander force-pushed the feature/global-search-sharees branch from 7aa7043 to 31de652 Compare March 3, 2023 17:01
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5485-7aa7043e7040aab90e41208da2b8151ec7d0e447-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

73.4% 73.4% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit ee19f8e into master Mar 3, 2023
@allexzander allexzander deleted the feature/global-search-sharees branch March 3, 2023 22:38
@allexzander
Copy link
Contributor Author

/backport to stable-3.7

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 3, 2023
Merged
@mgallien mgallien added this to the 3.8.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Query lookup server
4 participants
@allexzander @nextcloud-desktop-bot @claucambra @mgallien