Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new connect syntax #5451

Merged
merged 1 commit into from
Feb 28, 2023
Merged

use new connect syntax #5451

merged 1 commit into from
Feb 28, 2023

Conversation

mgallien
Copy link
Collaborator

mainly done using clazy and old-style-connect check

close #5426

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #5451 (01ecb63) into master (56b4787) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5451   +/-   ##
=======================================
  Coverage   57.83%   57.83%           
=======================================
  Files         141      141           
  Lines       18149    18149           
=======================================
+ Hits        10496    10497    +1     
+ Misses       7653     7652    -1     
Impacted Files Coverage Δ
src/libsync/account.cpp 36.19% <50.00%> (ø)
src/libsync/owncloudpropagator.h 65.87% <100.00%> (ø)
src/libsync/vfs/cfapi/cfapiwrapper.cpp 73.18% <0.00%> (+0.22%) ⬆️

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments but worth addressing

src/gui/wizard/slideshow.cpp Show resolved Hide resolved
@mgallien mgallien force-pushed the bugfix/connectNormalizedArgs branch from c6cf023 to a5aac28 Compare February 23, 2023 12:15
@mgallien mgallien force-pushed the bugfix/connectNormalizedArgs branch from a5aac28 to 34e3991 Compare February 27, 2023 08:58
mainly done using clazy and old-style-connect check

close #5426

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/connectNormalizedArgs branch from 34e3991 to 01ecb63 Compare February 28, 2023 08:36
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

20.0% 20.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5451-01ecb639abd20f1eb72e153d1f8bf0440183d159-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit a5d0d66 into master Feb 28, 2023
@mgallien mgallien deleted the bugfix/connectNormalizedArgs branch February 28, 2023 12:27
@mgallien
Copy link
Collaborator Author

/backport to stable-3.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression][bug]: Sync status is not available for libcloudproviders starting with 3.7 series
4 participants