Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.7] Fix share dialog infinite loading #5446

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5442

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.7.0 milestone Feb 16, 2023
@mgallien mgallien modified the milestones: 3.7.0, 3.7.4 Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #5446 (0f7384e) into stable-3.7 (4b9b068) will decrease coverage by 0.16%.
The diff coverage is 42.85%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.7    #5446      +/-   ##
==============================================
- Coverage       57.97%   57.82%   -0.16%     
==============================================
  Files             141      141              
  Lines           18133    18147      +14     
==============================================
- Hits            10513    10493      -20     
- Misses           7620     7654      +34     
Impacted Files Coverage Δ
src/libsync/account.cpp 35.92% <0.00%> (-0.34%) ⬇️
src/libsync/clientsideencryption.h 30.76% <ø> (ø)
src/libsync/clientsideencryption.cpp 26.07% <56.25%> (-0.78%) ⬇️
src/libsync/creds/abstractcredentials.cpp 14.28% <0.00%> (-57.15%) ⬇️
src/libsync/propagateremotemkdir.h 50.00% <0.00%> (-25.00%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.95% <0.00%> (-0.23%) ⬇️

…ermissions that would have previously prevented sharing

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the backport/5442/stable-3.7 branch from 265634e to 0f7384e Compare February 21, 2023 08:30
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5446-0f7384ed91f218f85e04886df6e9eae5dc7f8bc3-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit 6ea88ea into stable-3.7 Feb 21, 2023
@mgallien mgallien deleted the backport/5442/stable-3.7 branch February 21, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants