Improve config upgrade warning dialog #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilasan
commented
Feb 1, 2023
camilasan
commented
- Improve the code.
- Fix the check for the file name.
- Do not always display the warning about the backup of config files of older version.
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Camila <[email protected]>
mgallien
approved these changes
Feb 1, 2023
|
/backport to stable-3.7 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5384 +/- ##
=======================================
Coverage 57.99% 58.00%
=======================================
Files 141 141
Lines 18110 18113 +3
=======================================
+ Hits 10503 10506 +3
Misses 7607 7607
|
claucambra
approved these changes
Feb 1, 2023
mgallien
requested changes
Feb 1, 2023
Use the setting showConfigBackupWarning to change the default value. Signed-off-by: Camila <[email protected]>
camilasan
force-pushed
the
bugfix/improveConfigUpgradeWarningDialog
branch
from
6954827 to
72fe5f6
Compare
|
SonarCloud Quality Gate failed. |
|
AppImage file: nextcloud-PR-5384-72fe5f643cfa19499a3647901ceacaaff2b35471-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.