Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables #5290

Merged
merged 5 commits into from
Dec 20, 2022
Merged

Remove unused variables #5290

merged 5 commits into from
Dec 20, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Dec 19, 2022

Removes unused variables and procedures throughout the desktop client

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #5290 (bbb77dc) into master (0b70e49) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5290   +/-   ##
=======================================
  Coverage   57.50%   57.51%           
=======================================
  Files         139      139           
  Lines       17596    17594    -2     
=======================================
  Hits        10119    10119           
+ Misses       7477     7475    -2     
Impacted Files Coverage Δ
src/libsync/bulkpropagatorjob.cpp 73.18% <ø> (-0.08%) ⬇️
src/libsync/propagateremotemove.cpp 82.18% <ø> (-0.11%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.27% <0.00%> (-0.23%) ⬇️
src/libsync/discovery.cpp 86.22% <0.00%> (+0.28%) ⬆️

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 8313d79 into master Dec 20, 2022
@claucambra claucambra deleted the bugfix/remove-unused branch December 20, 2022 12:43
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5290-bbb77dc4f7b531aa14a86d2b30564a185e52a2a3-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants