Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.6] fix renaming of folders with a deep hierarchy inside them #5186

Merged
merged 8 commits into from
Nov 24, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Nov 18, 2022

  • ⚠️ This backport had conflicts and is incomplete

backport of #5182

currently broken test as we miss to rename recursively

Signed-off-by: Matthieu Gallien <[email protected]>
propagate renaming of parent folders to child recursively

Signed-off-by: Matthieu Gallien <[email protected]>
use QString::arg with multiple parameters because that is faster

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the backport/5182/stable-3.6 branch from 4381383 to 045159a Compare November 24, 2022 11:08
Signed-off-by: Matthieu Gallien <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5186-020e211b723db01b1f5ef6e7c3e311d8bfa69fb6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 742ecd6 into stable-3.6 Nov 24, 2022
@mgallien mgallien deleted the backport/5182/stable-3.6 branch November 24, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants