Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo of connector #5157

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Fix typo of connector #5157

merged 1 commit into from
Nov 14, 2022

Conversation

hefee
Copy link
Contributor

@hefee hefee commented Nov 9, 2022

a simple fix of typo found by Debian Lintian.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #5157 (aefb2f5) into master (fd561d7) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5157   +/-   ##
=======================================
  Coverage   57.56%   57.56%           
=======================================
  Files         138      138           
  Lines       17399    17399           
=======================================
  Hits        10016    10016           
  Misses       7383     7383

@mgallien mgallien merged commit b920b1c into master Nov 14, 2022
@mgallien mgallien deleted the hefee-patch-1 branch November 14, 2022 08:43
@mgallien mgallien added this to the 3.7.0 milestone Nov 14, 2022
@mgallien
Copy link
Collaborator

@rakekniven is it fine for translators if we backport this to the current stable branch ?
I am not sure because I would think that translators would prefer to have strings frozen in stable branches

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5157-14292ec8679db131929c72dd3c7c71cbc00d19c8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@rakekniven
Copy link
Member

@mgallien Feel free to backport. Actually the translation processes are not that mature and strict.

@mgallien
Copy link
Collaborator

/backport to stable-3.6

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 14, 2022
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hefee @mgallien @nextcloud-desktop-bot @rakekniven @claucambra