Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/5067/stable 3.6 #5153

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Backport/5067/stable 3.6 #5153

merged 2 commits into from
Nov 9, 2022

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Nov 9, 2022

backport of #5067 and #5148

@allexzander allexzander force-pushed the backport/5067/stable-3.6 branch from 25ac6f9 to 8a80055 Compare November 9, 2022 17:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5153-8a80055c1cfaccdd0e0cf59b7459a0ea17b81cdd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 9, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #5153 (8a80055) into stable-3.6 (1572fac) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Additional details and impacted files
@@              Coverage Diff               @@
##           stable-3.6    #5153      +/-   ##
==============================================
- Coverage       57.18%   57.02%   -0.17%     
==============================================
  Files             138      138              
  Lines           17187    17190       +3     
==============================================
- Hits             9829     9803      -26     
- Misses           7358     7387      +29     
Impacted Files Coverage Δ
src/libsync/account.cpp 37.92% <0.00%> (-0.46%) ⬇️
src/libsync/account.h 33.33% <ø> (ø)
src/libsync/clientsideencryption.cpp 26.96% <0.00%> (+0.08%) ⬆️
src/libsync/clientsideencryption.h 38.46% <ø> (ø)
src/libsync/vfs/cfapi/hydrationjob.cpp 52.68% <0.00%> (-3.77%) ⬇️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 83.33% <0.00%> (-2.44%) ⬇️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.83% <0.00%> (-1.37%) ⬇️
src/libsync/syncengine.cpp 86.65% <0.00%> (-0.55%) ⬇️
src/libsync/discovery.cpp 84.28% <0.00%> (-0.40%) ⬇️

@allexzander allexzander merged commit ceb2d89 into stable-3.6 Nov 9, 2022
@allexzander allexzander deleted the backport/5067/stable-3.6 branch November 9, 2022 18:02
@mgallien mgallien added this to the 3.6.2 milestone Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants