Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up methods in sync engine #5071

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

claucambra
Copy link
Collaborator

Small clean up that consists of:

  • Placing Q_INVOKABLE and void setters in slots
  • Removing getter for stopwatch unused anywhere in the code
  • Constifying methods that could be constified

Signed-off-by: Claudio Cambra [email protected]

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5071-133298fb7b9275b98583835ff3c5871d1638c8f8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean up
thanks for catching those "should have been" const methods

@mgallien mgallien force-pushed the work/sync-engine-method-cleanup branch from 133298f to 421f5e7 Compare October 25, 2022 09:05
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 25b556f into master Oct 25, 2022
@claucambra claucambra deleted the work/sync-engine-method-cleanup branch October 25, 2022 10:18
@mgallien mgallien added this to the 3.7.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants