Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server #4982

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

claucambra
Copy link
Collaborator

Signed-off-by: Claudio Cambra [email protected]

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #4982 (c671414) into master (4e3e8be) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4982   +/-   ##
=======================================
  Coverage   57.11%   57.11%           
=======================================
  Files         138      138           
  Lines       17228    17228           
=======================================
  Hits         9840     9840           
  Misses       7388     7388           
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.42% <0.00%> (-0.23%) ⬇️
src/libsync/propagatedownload.cpp 64.75% <0.00%> (+0.14%) ⬆️

…date even when maximum date enforcement is disabled on the server

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the bugfix/enforced-max-expire-date-link-share-fix branch from b7cb652 to c671414 Compare October 3, 2022 20:27
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4982-c67141430b347c3e9dc4741daf3856882b635ee6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit e5d5471 into master Oct 3, 2022
@claucambra claucambra deleted the bugfix/enforced-max-expire-date-link-share-fix branch October 3, 2022 23:13
@mgallien mgallien added this to the 3.7.0 milestone Oct 4, 2022
@claucambra
Copy link
Collaborator Author

/backport to stable-3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants