Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder item for empty activity list #4959

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Sep 20, 2022

Adds a placeholder item for empty activity lists (e.g. file has no recent activities)

Below screenshot is a simulated example of an empty activity list in the system tray as I didn't have any files not modified in the past 6 months

Screenshot 2022-09-20 at 17 54 36

Closes #4342

Signed-off-by: Claudio Cambra [email protected]

@claucambra claucambra self-assigned this Sep 20, 2022
@claucambra claucambra force-pushed the feature/activity-list-placeholder branch from eb4ff28 to bc5ab59 Compare September 20, 2022 16:38
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #4959 (bc5ab59) into master (51f3131) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head bc5ab59 differs from pull request most recent head bc08559. Consider uploading reports for the commit bc08559 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4959      +/-   ##
==========================================
- Coverage   56.98%   56.98%   -0.01%     
==========================================
  Files         138      138              
  Lines       17232    17232              
==========================================
- Hits         9820     9819       -1     
- Misses       7412     7413       +1     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.60% <0.00%> (-0.23%) ⬇️

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@claucambra claucambra force-pushed the feature/activity-list-placeholder branch from bc5ab59 to bc08559 Compare September 22, 2022 10:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 0552a3a into master Sep 22, 2022
@claucambra claucambra deleted the feature/activity-list-placeholder branch September 22, 2022 11:01
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-4959-bc08559655181029af408eec7f28ee4b6ffba2a7-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.7.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity url is wrong
3 participants