Refactor user line #4797
Merged
Refactor user line #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
+ Coverage 57.21% 57.23% +0.02%
==========================================
Files 138 138
Lines 17144 17144
==========================================
+ Hits 9809 9813 +4
+ Misses 7335 7331 -4
|
allexzander
approved these changes
Aug 9, 2022
camilasan
approved these changes
Aug 10, 2022
claucambra
force-pushed
the
work/user-line-refactor
branch
from
52866c9 to
be8e2f5
Compare
Signed-off-by: Claudio Cambra <[email protected]>
claucambra
force-pushed
the
work/user-line-refactor
branch
from
be8e2f5 to
387dfa9
Compare
|
AppImage file: Nextcloud-PR-4797-387dfa96a1b8c47b6c9138a70121c659c4a0dc95-x86_64.AppImage |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the code in
UserLine.qmlis messy and has a lot of layout bugs.This PR refactors
UserLineso that it is sanely structured and properly considers layout restrictions and label widths. Labels should no longer elide randomly (or not at all).