-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make client language gender-neutral and more clear #4667
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -125,7 +125,7 @@ class EchoDisabler | |
QString queryPassword(const QString &user) | ||
{ | ||
EchoDisabler disabler; | ||
std::cout << "Password for user " << qPrintable(user) << ": "; | ||
std::cout << "Password for account with username " << qPrintable(user) << ": "; | ||
std::string s; | ||
std::getline(std::cin, s); | ||
return QString::fromStdString(s); | ||
|
@@ -383,7 +383,7 @@ int main(int argc, char **argv) | |
|
||
if (options.interactive) { | ||
if (user.isEmpty()) { | ||
std::cout << "Please enter user name: "; | ||
std::cout << "Please enter username: "; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is basically the same though. ;) We should not have the word "user" anywhere, thus "Please enter account name: " would be a proper fix. |
||
std::string s; | ||
std::getline(std::cin, s); | ||
user = QString::fromStdString(s); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,7 @@ AuthenticationDialog::AuthenticationDialog(const QString &realm, const QString & | |
lay->addWidget(label); | ||
|
||
auto *form = new QFormLayout; | ||
form->addRow(tr("&User:"), _user); | ||
form->addRow(tr("&Username:"), _user); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure this is actual wording, but "Account" would be correct here too. |
||
form->addRow(tr("&Password:"), _password); | ||
lay->addLayout(form); | ||
_password->setEchoMode(QLineEdit::Password); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,7 +96,7 @@ void HttpCredentialsGui::showDialog() | |
{ | ||
QString msg = tr("Please enter %1 password:<br>" | ||
"<br>" | ||
"User: %2<br>" | ||
"Username: %2<br>" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Account: " here too |
||
"Account: %3<br>") | ||
.arg(Utility::escape(Theme::instance()->appNameGUI()), | ||
Utility::escape(_user), | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,7 +90,7 @@ | |
</font> | ||
</property> | ||
<property name="text"> | ||
<string>User name</string> | ||
<string>Username</string> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Account name |
||
</property> | ||
<property name="alignment"> | ||
<set>Qt::AlignCenter</set> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1240,7 +1240,7 @@ bool ClientSideEncryption::newMnemonicGenerated() const | |
void ClientSideEncryption::decryptPrivateKey(const AccountPtr &account, const QByteArray &key) { | ||
QString msg = tr("Please enter your end to end encryption passphrase:<br>" | ||
"<br>" | ||
"User: %2<br>" | ||
"Username: %2<br>" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Account name |
||
"Account: %3<br>") | ||
.arg(Utility::escape(account->credentials()->user()), | ||
Utility::escape(account->displayName())); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just "Password for account " is enough.