Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/enable Windows CI unit tests and test coverage #4609

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander force-pushed the bugfix/enable-windows-ci-testing branch from 57f281f to 449abb2 Compare June 2, 2022 11:24
@codecov
Copy link

codecov bot commented Jun 2, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@90a2f12). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 416149e differs from pull request most recent head 3004465. Consider uploading reports for the commit 3004465 to get more accurate results

@@            Coverage Diff            @@
##             master    #4609   +/-   ##
=========================================
  Coverage          ?   56.42%           
=========================================
  Files             ?      138           
  Lines             ?    17070           
  Branches          ?        0           
=========================================
  Hits              ?     9632           
  Misses            ?     7438           
  Partials          ?        0           

@allexzander allexzander closed this Jun 2, 2022
@allexzander allexzander reopened this Jun 2, 2022
@allexzander allexzander force-pushed the bugfix/enable-windows-ci-testing branch from 416149e to 21a1ebd Compare June 2, 2022 16:58
@allexzander allexzander marked this pull request as ready for review June 2, 2022 17:22
@allexzander allexzander changed the title Bugfix/enable windows ci testing Bugfix/enable Windows CI unit tests and test coverage Jun 2, 2022
@allexzander allexzander linked an issue Jun 7, 2022 that may be closed by this pull request
4 tasks
@allexzander allexzander force-pushed the bugfix/enable-windows-ci-testing branch from d5bba4c to 1fa3de7 Compare June 10, 2022 11:06
@allexzander allexzander requested a review from mgallien June 10, 2022 11:07
@allexzander
Copy link
Contributor Author

@mgallien All done

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

@allexzander allexzander force-pushed the bugfix/enable-windows-ci-testing branch from 1fa3de7 to 9249b58 Compare June 10, 2022 11:26
…indows tests. Create coverage and uppload it to codecov.io.

Signed-off-by: alex-z <[email protected]>
@allexzander allexzander force-pushed the bugfix/enable-windows-ci-testing branch from d7bc7b9 to 3004465 Compare June 10, 2022 12:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4609-300446579cf1026ed172841a67c20d74e2e63591-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit 22e136a into master Jun 10, 2022
@allexzander allexzander deleted the bugfix/enable-windows-ci-testing branch June 10, 2022 14:18
@mgallien mgallien added this to the 3.6.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix automated tests to not fail on Windows and make them mandatory
4 participants