Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not replace strings in action links coming from the notification api. #4522

Merged
merged 1 commit into from
May 12, 2022

Conversation

camilasan
Copy link
Member

Doing what I discussed with @nimishavijay in #4518 (comment).

Just thought that we might not want to have this in a bugfix release so it would be better to have it in a different PR.

dismiss

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If possible, we should the primary action to "Call back", and "Reply" and "Dismiss" would be secondary actions. If not possible because of the API then no worries :)

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4522-e4a0d57bc8abed89425eefd4ffd4e349e35cbc9e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit dc5bdb2 into master May 12, 2022
@mgallien mgallien deleted the bugfix/notification-wording branch May 12, 2022 18:47
@mgallien mgallien added this to the 3.6.0 milestone May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants