Revamp notifications for macOS and add support for actionable update notifications #4512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.5 |
|
/backport to stable-3.4 |
claucambra
force-pushed
the
feature/macos-notifications
branch
from
b2f1170 to
c843283
Compare
camilasan
approved these changes
May 11, 2022
mgallien
approved these changes
May 11, 2022
…date notifications Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
feature/macos-notifications
branch
from
c843283 to
c22d595
Compare
|
AppImage file: Nextcloud-PR-4512-c22d5959b8ebc018bfba421acae346f03e27a37e-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of macOS notification support uses deprecated code that prevents us from meaningfully customising notifications and making them more interactive (and thus more useful).
This PR reimplements our notification support by using Apple's UserNotifications framework, which allows us a lot more flexibility with what we can do with notifications.
Thanks to this, this PR also implements support for interactive update notifications which, upon clicking, redirect the user to the download page for the desktop client when we are not using the Sparkle auto-updater.