Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/allow manual rename files with spaces #4454

Merged
merged 1 commit into from
May 16, 2022
Merged

Bugfix/allow manual rename files with spaces #4454

merged 1 commit into from
May 16, 2022

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Apr 22, 2022 •
edited
Loading

What's changed:

  • Do not remove leading and trailing spaces automatically
  • Allow manual renaming via dialog
  • Allow accepting leading and trailing spaces in files when uploading them for the first time
  • As a consequence - now, files and folders with leading/trailing spaces are correctly downloaded (this was broken when automatic renaming was introduced)

@allexzander allexzander force-pushed the bugfix/allow-manual-rename-files-with-spaces branch 6 times, most recently from 9eeac44 to 5141769 Compare May 4, 2022 08:06
@allexzander allexzander marked this pull request as ready for review May 4, 2022 08:11
claucambra
claucambra approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great!

src/libsync/discovery.cpp Outdated Show resolved Hide resolved
mgallien
mgallien requested changes May 13, 2022
View reviewed changes
src/libsync/syncengine.cpp Outdated Show resolved Hide resolved
src/libsync/discovery.cpp Outdated Show resolved Hide resolved
src/libsync/discovery.cpp Outdated Show resolved Hide resolved
test/testlocaldiscovery.cpp Outdated Show resolved Hide resolved
test/testlocaldiscovery.cpp Outdated Show resolved Hide resolved
test/testsyncvirtualfiles.cpp Outdated Show resolved Hide resolved
test/testsyncvirtualfiles.cpp Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from mgallien May 13, 2022 16:37
@allexzander
Copy link
Contributor Author

/backport to stable-3.5

@allexzander
Copy link
Contributor Author

@mgallien Have I answered your questions?

@allexzander
Allow manual renaming of files and folders with spaces. Allow uploadi…
53654b2 
…ng invalid file name via the InvalidFileName dialog.

Signed-off-by: alex-z <[email protected]>
@allexzander allexzander force-pushed the bugfix/allow-manual-rename-files-with-spaces branch from 139a3c2 to 53654b2 Compare May 16, 2022 15:07
@allexzander allexzander merged commit fc8bfdc into master May 16, 2022
@allexzander allexzander deleted the bugfix/allow-manual-rename-files-with-spaces branch May 16, 2022 15:08
@allexzander
Copy link
Contributor Author

/backport to stable-3.5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 16, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 16, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien added this to the 3.6.0 milestone May 16, 2022
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4454-53654b2a505ac2b6b56eac83b0a4696125f1c30e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien mentioned this pull request Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @mgallien @claucambra