Show main dialog as normal window if tray icons not available #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
force-pushed
the
feature/main-dialog-regular-window-when-no-tray-icon
branch
4 times, most recently
from
86c6289 to
bfb9642
Compare
mgallien
requested changes
Jun 23, 2021
mgallien
reviewed
Jun 25, 2021
|
/rebase |
github-actions
bot
force-pushed
the
feature/main-dialog-regular-window-when-no-tray-icon
branch
from
3554a29 to
8591242
Compare
mgallien
force-pushed
the
feature/main-dialog-regular-window-when-no-tray-icon
branch
from
8591242 to
14b5471
Compare
mgallien
requested changes
Jul 9, 2021
|
by the way I used that commandline to check the data type of qproperties; |
|
when tested under Gnome, I still get a close button that we do not want at all (too easy to close the window with no way to open it again |
|
/rebase |
github-actions
bot
force-pushed
the
feature/main-dialog-regular-window-when-no-tray-icon
branch
from
eec5711 to
dc9ec43
Compare
mgallien
reviewed
Jul 12, 2021
mgallien
approved these changes
Jul 12, 2021
allexzander
approved these changes
Jul 12, 2021
FlexW
force-pushed
the
feature/main-dialog-regular-window-when-no-tray-icon
branch
from
ae43644 to
d09175d
Compare
|
/rebase |
Fixes #3307 Signed-off-by: Felix Weilbach <[email protected]>
github-actions
bot
force-pushed
the
feature/main-dialog-regular-window-when-no-tray-icon
branch
from
d09175d to
efaccbd
Compare
|
AppImage file: Nextcloud-PR-3468-efaccbd6fd0a9c00e7a788e76e7edfd81e7e8b36-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3307
Signed-off-by: Felix Weilbach [email protected]