Remove html tags from strings that may appear in notifications #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content of notifications on MacOS are not allowed to contain HTML tags in it. Linux (Free Desktop) notifications may contain HTML tags in their content. However, it is optional that the notification daemon interprets the tags. The GNOME notification daemon does not interpret HTML tags and even does not strip them off. KDE's daemon interprets the tags. For now I think it's the best solution to remove the HTML tags. In the future we should fire a action if the user clicks on the notification and react on it and open the link then. This should work on all platforms. But as this change involves working with the native MacOS api and I don't have hardware for that at the moment for that I will postpone it. Fixes #2200 Signed-off-by: Felix Weilbach <[email protected]>
FlexW
force-pushed
the
bugfix/remove-html-tags-from-notifications
branch
from
46de813 to
b2377ff
Compare
|
AppImage file: Nextcloud-PR-3052-b2377ff64f31bf624c7fcecaaac2e69ef1fd11cb-x86_64.AppImage |
camilasan
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.
Fixes #2200
Signed-off-by: Felix Weilbach [email protected]