Increase logging around file removal events #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
force-pushed
the
feature/increase-file-removal-logging
branch
from
fcb0f2d to
94c54c9
Compare
allexzander
reviewed
Mar 19, 2021
allexzander
approved these changes
Mar 19, 2021
FlexW
force-pushed
the
feature/increase-file-removal-logging
branch
from
94c54c9 to
bfcb375
Compare
|
/rebase |
To better see what is going on when and if files are removed by the client. See also: #260, #1433, #2913 Signed-off-by: Felix Weilbach <[email protected]>
github-actions
bot
force-pushed
the
feature/increase-file-removal-logging
branch
from
bfcb375 to
b1983d7
Compare
|
AppImage file: Nextcloud-PR-3020-b1983d7d19a8258159909f975941eccb0d73e3c7-x86_64.AppImage |
er-vin
reviewed
Mar 22, 2021
| @@ -89,13 +89,15 @@ bool PropagateLocalRemove::removeRecursively(const QString &path) | |||
|
|
|||
| void PropagateLocalRemove::start() | |||
| { | |||
| qCInfo(lcPropagateLocalRemove) << "Start propagate local remove job"; | |||
There was a problem hiding this comment.
I'd let go that one to avoid double logging in the common case. If you don't get to the second one it's due to an abort anyway so it's as if the job was never started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better see what is going on when and if files are removed by the
client.
See also: #260, #1433, #2913