-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Windows CreateFile long path #3016
Conversation
2610d3f
to
3fccacd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
/rebase |
Signed-off-by: allexzander <[email protected]>
Signed-off-by: allexzander <[email protected]>
3fccacd
to
5f0344a
Compare
AppImage file: Nextcloud-PR-3016-5f0344abb2d43e50307412848b1b417b955f4b6a-x86_64.AppImage |
Will this fix already available in the nightly build for windows? |
@cscholz |
@@ -370,17 +371,24 @@ bool OCC::CfApiWrapper::isSparseFile(const QString &path) | |||
|
|||
OCC::CfApiWrapper::FileHandle OCC::CfApiWrapper::handleForPath(const QString &path) | |||
{ | |||
if (path.isEmpty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a Q_ASSERT(!path.isEmpty());
before this if. This is clearly an error in the caller when that happens so better crash hard and catch it in debug builds.
This should fix #3006