Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Windows CreateFile long path #3016

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

allexzander
Copy link
Contributor

This should fix #3006

@allexzander allexzander changed the title Fix for win createfile long path Fix for Windows CreateFile long path Mar 17, 2021
@allexzander allexzander force-pushed the fix_for_win_createfile_long_path branch 3 times, most recently from 2610d3f to 3fccacd Compare March 17, 2021 08:53
Copy link

@FlexW FlexW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@allexzander
Copy link
Contributor Author

/rebase

@allexzander allexzander force-pushed the fix_for_win_createfile_long_path branch from 3fccacd to 5f0344a Compare March 18, 2021 10:07
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3016-5f0344abb2d43e50307412848b1b417b955f4b6a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@cscholz
Copy link

cscholz commented Mar 18, 2021

Will this fix already available in the nightly build for windows?

@allexzander allexzander merged commit 6abb0b2 into master Mar 18, 2021
@allexzander allexzander deleted the fix_for_win_createfile_long_path branch March 18, 2021 10:34
@allexzander
Copy link
Contributor Author

Will this fix already available in the nightly build for windows?

@cscholz
Crossing all fingers. If Windows build succeeds, then, yes, it will be there.

@@ -370,17 +371,24 @@ bool OCC::CfApiWrapper::isSparseFile(const QString &path)

OCC::CfApiWrapper::FileHandle OCC::CfApiWrapper::handleForPath(const QString &path)
{
if (path.isEmpty()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a Q_ASSERT(!path.isEmpty()); before this if. This is clearly an error in the caller when that happens so better crash hard and catch it in debug builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client 3.2 RC 1 - Couldn't set the default inherit pin state
6 participants