Split content of User::isValueableActivity() #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
force-pushed
the
refactor/split-out-valuable-activities
branch
from
80b2776 to
9a66adf
Compare
er-vin
reviewed
Mar 9, 2021
FlexW
force-pushed
the
refactor/split-out-valuable-activities
branch
from
d906a5c to
84b402a
Compare
er-vin
approved these changes
Mar 10, 2021
|
/rebase |
added 2 commits
March 11, 2021 09:42
Refactoring of User::isValueableactivity() because of changes introduced with merge commit f17c52d. Signed-off-by: Felix Weilbach <[email protected]>
Signed-off-by: Felix Weilbach <[email protected]>
github-actions
bot
force-pushed
the
refactor/split-out-valuable-activities
branch
from
84b402a to
e3ac63e
Compare
|
AppImage file: Nextcloud-PR-2976-e3ac63e9ff850e0628cbdc5f067afa57b643b1ae-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of User::isValueableactivity() because of changes
introduced with merge commit f17c52d.
I like splitting out the checks in separate methods because I find it more readable and the User::slotItemCompleted() is at the moment way to big for my taste.
Signed-off-by: Felix Weilbach [email protected]