Add missing error handling for downloads of client side encryption #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
reviewed
Mar 9, 2021
FlexW
force-pushed
the
bugfix/fix-missing-error-handling-download-encrypted
branch
from
e89886e to
a67c73d
Compare
er-vin
approved these changes
Mar 10, 2021
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/fix-missing-error-handling-download-encrypted
branch
from
a67c73d to
241ff1e
Compare
|
/rebase |
The missing error handlers can cause the sync to hang forever Signed-off-by: Felix Weilbach <[email protected]>
github-actions
bot
force-pushed
the
bugfix/fix-missing-error-handling-download-encrypted
branch
from
241ff1e to
88426de
Compare
|
AppImage file: Nextcloud-PR-2967-88426de4ddf18d9a6b78200bf21885df68214c5e-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing error handlers can cause the sync to hang forever
Signed-off-by: Felix Weilbach [email protected]