Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the providers ssl certificate #2919

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

FlexW
Copy link

@FlexW FlexW commented Feb 10, 2021

Signed-off-by: Felix Weilbach [email protected]

@er-vin
Copy link
Member

er-vin commented Feb 10, 2021

Note this means it will also change the behavior for webflow (not flow2) auths. Previously it'd silently accepted self-signed certificates of such servers but not anymore. I personally think this is a change for the better but I expect some users might disagree. Just something to keep in mind.

@er-vin
Copy link
Member

er-vin commented Feb 12, 2021

/rebase

@github-actions github-actions bot force-pushed the validate_ssl_providers_certificate branch from 21a189b to 74d07e2 Compare February 12, 2021 08:26
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-2919-74d07e28cf1218555f067b938c0d7a32ac2ce2af-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@er-vin er-vin merged commit 81831fd into master Feb 12, 2021
@er-vin er-vin deleted the validate_ssl_providers_certificate branch February 12, 2021 09:50
@er-vin
Copy link
Member

er-vin commented Feb 12, 2021

/backport to stable-3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants