Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the theme resource explictly #2900

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

er-vin
Copy link
Member

@er-vin er-vin commented Feb 2, 2021

Otherwise they won't be loaded automatically at startup leading to lots
of missing icons. Since they're now in a static library they need that
explicit loading.

This fix a regression introduced by #2834

Otherwise they won't be loaded automatically at startup leading to lots
of missing icons. Since they're now in a static library they need that
explicit loading.

Signed-off-by: Kevin Ottens <[email protected]>
@er-vin er-vin force-pushed the make_sure_theme_resources_are_loaded branch from 88b7d6e to 55fd056 Compare February 2, 2021 17:33
@er-vin er-vin changed the title Link the resources with the app not the static library Load the theme resource explictly Feb 2, 2021
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-2900-55fd0562dee45a08498c3b507270ef96365bb363-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@FlexW FlexW merged commit 6803256 into master Feb 2, 2021
@FlexW FlexW deleted the make_sure_theme_resources_are_loaded branch February 2, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants