Repair E2EE on sync folders which don't point to the root of the server on the remote end #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
approved these changes
Feb 4, 2021
|
/rebase |
added 2 commits
February 4, 2021 11:16
This got broken during the huge discovery refactoring. I wrongly passed the mangled name as is out of discovery, but coming from listing jobs it was fully qualified while the jobs at propagation time and the db expect those paths to be relative to the remote folder. Signed-off-by: Kevin Ottens <[email protected]>
Indeed the path we have is supposedly not fully qualified in case of a sync folder which doesn't point to / on the remote end. But LSCOL works with absolute paths on the server so make sure this is what we give it out. Signed-off-by: Kevin Ottens <[email protected]>
github-actions
bot
force-pushed
the
repair_e2ee_on_non_remote_root_sync_folder
branch
from
f788d68 to
856f056
Compare
|
AppImage file: Nextcloud-PR-2892-856f0567a7488fc34eb79af705bb25b92f3f6a99-x86_64.AppImage |
|
The fix works for me. Thanks! I am also impressed with the performance. Looking forward to the official release. |
Excellent news, thanks for your time testing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a couple of regressions related to the use of E2EE in the context of sync folders configured to not point to / but to some other subfolders on the server. They were introduced during the big changes in the discovery which made the content of the e2eMangledName field change in the database with a different convention to what almost all the jobs were expecting. The only exception was one place in the newer changes done by @allexzander around deletion.