Handle SVG branded clients #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2021 10:10
Somehow this was missing Signed-off-by: Kevin Ottens <[email protected]>
Also mention the svg possibly used in the wizard Signed-off-by: Kevin Ottens <[email protected]>
er-vin
requested review from
camilasan,
tobiasKaminsky,
allexzander and
FlexW
tobiasKaminsky
approved these changes
Jan 20, 2021
allexzander
reviewed
Jan 20, 2021
added 2 commits
January 20, 2021 15:09
Signed-off-by: Kevin Ottens <[email protected]>
We now favor APPLICATION_ICON_SET to isBranded() regarding the decision to use PNG or SVG for icons. Signed-off-by: Kevin Ottens <[email protected]>
er-vin
force-pushed
the
handle_svg_branded_clients
branch
from
75d408e to
471bb25
Compare
|
AppImage file: Nextcloud-PR-2844-471bb25e62c6748d656b6cdc627ec1beadd070e9-x86_64.AppImage |
allexzander
approved these changes
Jan 20, 2021
|
/backport to stable-3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that brander can tell us is customers use PNG or SVG for their branding we better use this than rely on our old heuristic which was forcing PNG as soon as the client is branded.