Fix CfAPI Win32 build #2801
Merged
Fix CfAPI Win32 build #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 7, 2021 13:40
This reverts commit 3b38642.
MSVC having so useless error messages it didn't quite point to the root cause of the issue... it turns out that through the maze of macros defined in the windows API, there's one which impacted the function pointer definition of CfCloseHandle which would then not convert to FileHandle::Deleter as expected. So I end up wrapping it in a lambda to help... luckily this kind of lambdas decay into a simple function pointer so there's likely no overhead it's just to coerce the compiler into doing the right thing. Signed-off-by: Kevin Ottens <[email protected]>
|
AppImage file: Nextcloud-PR-2801-2d8eb19ee5a9c4cc78b7d70a19855483466217db-x86_64.AppImage |
allexzander
approved these changes
Jan 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time for real it seems. :-)