Remove NO_SHIBBOLETH flag and dead code #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
approved these changes
Jan 5, 2021
er-vin
requested changes
Jan 5, 2021
There was a problem hiding this comment.
Actually, change of mind. You should also adjust the .drone.yml file and the admin/linux/build-appimage.sh files. They don't need to pass NO_SHIBBOLETH anymore.
Bonus point for then adjusting client-building as well in another PR (different repository anyway)
Signed-off-by: Felix Weilbach <[email protected]>
|
I have updated the files. I also updated doc/building.rst. |
|
AppImage file: Nextcloud-PR-2794-db0f1e245df27e5673df0931da0e4e0f56e1c0b6-x86_64.AppImage |
er-vin
approved these changes
Jan 5, 2021
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Apr 17, 2021
[1] nextcloud/desktop#2794 git-svn-id: file:///srv/repos/svn-community/svn@919802 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Apr 17, 2021
[1] nextcloud/desktop#2794 git-svn-id: file:///srv/repos/svn-community/svn@919802 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.