Cherry pick updater fixes and improvements #2647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
requested review from
rullzer,
camilasan,
allexzander and
DominiqueFuchs
|
/rebase |
github-actions
bot
force-pushed
the
cherry_pick_updater_fixes_and_improvements
branch
from
6f90b6b to
4430434
Compare
camilasan
approved these changes
Nov 24, 2020
|
/rebase |
github-actions
bot
force-pushed
the
cherry_pick_updater_fixes_and_improvements
branch
from
4430434 to
cbaeda4
Compare
|
/rebase |
We can extend on this to give UI feedback.
(cherry picked from commit dfdc2e1e87f99d387a042f4983c999fbb7fcf3d9)
'auto' here is a QStringBuilder referencing a temporary Ammend commit 150d4f5 (MSI: Always with logfile #6609) Found in the crash reporter: https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/
The xml looks like this: <version>2.5.0.328</version> <versionstring>ownCloud Client 2.5.0 alpha1 (build 238)</versionstring> And we should show the version string Issue #6602
Signed-off-by: Kevin Ottens <[email protected]>
The problem was accessing the lines with an off by one error, while printing the log. Other problem included the fact that QDebug added spaces, quotes, and other things which made the error lot look right in the console. Issue #7545
Fixes: #8074
Signed-off-by: Kevin Ottens <[email protected]>
github-actions
bot
force-pushed
the
cherry_pick_updater_fixes_and_improvements
branch
from
cbaeda4 to
4906353
Compare
|
AppImage file: Nextcloud-PR-2647-4906353f2e1817cf4f97a253d19e07a874a5f21f-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This opens the door to the support for msi based updates (although the server side doesn't provide them yet). This should also get the sparkle based updates on Mac to work (this would need to be tested further though).
Also contains nice improvements regarding the logging of the updater and error handling.