Delay initialization of SettingsDialog #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
approved these changes
Oct 22, 2020
|
/rebase |
ownCloudGui::slotShowSettings already got what it takes to create it only when we try to show it for the first time. This however has some implications: Pros: - Only created when needed, while testing saved ca. 20 MB of RAM and got freed again after closing the dialog. - Since we defaulted to the new Tray UI from 3.0, this is an added bonus for users don't opening the settings. Cons: - Resources like the avatar image have to be refetched everytime the dialog is recreated. This may be desired as well, because it ensures displaying no outdated info (e.g. on connection issues). Signed-off-by: Michael Schuster <[email protected]>
setWindowFlags triggered changeEvent, thus causing a crash in customizeStyle. This fix should be kept even if we decide against delayed init in the future. Signed-off-by: Michael Schuster <[email protected]>
github-actions
bot
force-pushed
the
delay-settingsdialog-init
branch
from
2b16ab2 to
7699004
Compare
|
AppImage file: Nextcloud-PR-2580-7699004a11f896962dc7c6ba0b0920fad3dc902b-x86_64.AppImage |
er-vin
pushed a commit
that referenced
this pull request
Nov 9, 2020
Because of PR #2580 the settings dialog doesn't always exist. We need to check for it first before placing calls to it. Signed-off-by: Kevin Ottens <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 10, 2020
Because of PR #2580 the settings dialog doesn't always exist. We need to check for it first before placing calls to it. Signed-off-by: Kevin Ottens <[email protected]>
PraMiD
pushed a commit
to PraMiD/nextcloud-desktop
that referenced
this pull request
Dec 30, 2020
Because of PR nextcloud#2580 the settings dialog doesn't always exist. We need to check for it first before placing calls to it. Signed-off-by: Kevin Ottens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @er-vin in #2197's review.
ownCloudGui::slotShowSettingsalready got what it takes to create it only when we try to show it for the first time:https://github.com/nextcloud/desktop/blob/2b16ab2565ae7c7a8bfdb86f58daa1d26d342e6e/src/gui/owncloudgui.cpp#L556-L564
This however has some implications:
Pros:
Cons:
This may be desired as well, because it ensures displaying no outdated info (e.g. on connection issues).
Fix crash in
SettingsDialogwith delayed initializationsetWindowFlagstriggeredchangeEvent, thus causing a crash incustomizeStyle.This fix should be kept even if we decide against delayed init in the future.