Fix share dialog animation for enforced password policy #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
camilasan
approved these changes
Oct 19, 2020
added 3 commits
October 19, 2020 14:33
It turns out the shareDeleted() signal is connected to a function cleaning up the ShareLinkWidget holding the last shared pointer to the Share object. Since we use member variables for calling updateFolder() this would lead to using deleted objects. Just swap the call and the signal to have everything back in order. Signed-off-by: Kevin Ottens <[email protected]>
All the other ShareLinkWidgets process that signal (which allows to display error messages for instance) but not that one for some reason. That being said it might need to deal with an enforced password situation. Signed-off-by: Kevin Ottens <[email protected]>
Otherwise it would spin forever while we know we're not doing any work anymore since we got a message from the server. Signed-off-by: Kevin Ottens <[email protected]>
github-actions
bot
force-pushed
the
fix_share_dialog_animation_for_enforced_password_policy
branch
from
eff33ca to
b7ea653
Compare
|
AppImage file: Nextcloud-PR-2551-b7ea6530c5d3f3a62cdfeea8f4b1a46e671dba96-x86_64.AppImage |
er-vin
deleted the
fix_share_dialog_animation_for_enforced_password_policy
branch
|
/backport to stable-3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without those changes, the spinner would be displayed forever when adding a new link and hitting cancel on the input box asking for the enforced password.