Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ask for optional password capability #2520

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Handle ask for optional password capability #2520

merged 3 commits into from
Oct 7, 2020

Conversation

er-vin
Copy link
Member

@er-vin er-vin commented Oct 6, 2020

No description provided.

rullzer
rullzer approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@er-vin
Copy link
Member Author

er-vin commented Oct 7, 2020

/rebase

Kevin Ottens added 3 commits October 7, 2020 09:43
@er-vin
Add sharePublicLinkAskOptionalPassword to Capabilities
e356acb 
Signed-off-by: Kevin Ottens <[email protected]>
@er-vin
Since we must ask for a password this can't be a default public link
099d25a 
Signed-off-by: Kevin Ottens <[email protected]>
@er-vin
If askForOptionalPassword is enabled preset a random password
e78312f 
This is the same approach used on the server side. Turns out I quite
like it, this avoids popping up a dialog to the user and since she won't
know the password she'll have to set a new one anyway or disable it.

Signed-off-by: Kevin Ottens <[email protected]>
@github-actions github-actions bot force-pushed the handle_askForOptionalPassword_capability branch from f4f9dd1 to e78312f Compare October 7, 2020 09:43
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-2520-e78312f094f8101a6eea649972317b6a0d65f66b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@misch7 misch7 merged commit f90ae66 into master Oct 7, 2020
@misch7 misch7 deleted the handle_askForOptionalPassword_capability branch October 7, 2020 13:30
@misch7 misch7 added feature: 👥 sharing Sharing dialog and functionalities. feature: 🔑 authentication labels Oct 7, 2020
@misch7 misch7 added this to the Desktop 3.0 milestone Oct 7, 2020
@misch7
Copy link
Member

misch7 commented Oct 7, 2020

/backport to stable-3.0

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 7, 2020
Merged
@er-vin er-vin mentioned this pull request Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominiqueFuchs DominiqueFuchs DominiqueFuchs left review comments

@rullzer rullzer rullzer approved these changes

@camilasan camilasan camilasan approved these changes

@misch7 misch7 misch7 approved these changes

@sbeyer sbeyer Awaiting requested review from sbeyer

Assignees
No one assigned
Labels
feature: 👥 sharing Sharing dialog and functionalities.
Projects
None yet
Milestone
Desktop 3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@er-vin @nextcloud-desktop-bot @misch7 @rullzer @camilasan @DominiqueFuchs