Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS: Fix memory leak in FolderWatcherPrivate::startWatching #2497

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

misch7
Copy link
Member

@misch7 misch7 commented Oct 1, 2020

Originally this was part of #2155 but we should merge it rather sooner than later 😉

Also fixes some source file access modes.

@misch7 misch7 added this to the Desktop 3.0 milestone Oct 1, 2020
@misch7 misch7 requested review from camilasan and er-vin October 1, 2020 21:47
@misch7
Copy link
Member Author

misch7 commented Oct 2, 2020

/rebase

@github-actions github-actions bot force-pushed the fix/mac-folderwatcher-memory-leak branch from 4b944a2 to bb30633 Compare October 2, 2020 16:56
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-2497-bb30633d3154f9de9e76566590573abf86c4c01f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@misch7 misch7 merged commit a0b351b into master Oct 2, 2020
@misch7 misch7 deleted the fix/mac-folderwatcher-memory-leak branch October 2, 2020 17:30
@misch7
Copy link
Member Author

misch7 commented Oct 2, 2020

/backport to stable-3.0

@misch7
Copy link
Member Author

misch7 commented Oct 2, 2020

/backport to stable-2.6

@backportbot-nextcloud

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants