Make QML code more declarative by using properties #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
github-actions
bot
force-pushed
the
declarative
branch
from
217c1c9 to
92ceef8
Compare
nicolasfella
changed the title
|
Needs some care for when no accounts are availabe |
|
Ping? |
nicolasfella
force-pushed
the
declarative
branch
from
92ceef8 to
0696f9a
Compare
nicolasfella
changed the title
|
/rebase |
github-actions
bot
force-pushed
the
declarative
branch
from
0696f9a to
fdcddfd
Compare
er-vin
requested changes
Oct 7, 2020
nicolasfella
force-pushed
the
declarative
branch
from
fdcddfd to
a473a55
Compare
|
/rebase |
By using properties and property bindings the QML code gets more declarative rather than imperative, which is considered better. This patch: - Introduces a currentUserId property in UserModel that replaces the equivalent Q_INVOKABLE call - Introduces an avatar property in User that contains the avatar's image provider url without any fallback - Introduces new image provider urls for fallback images - Moves the fallback image selection to QML since we want different fallbacks according to where it is used - Wires up the necessary signals to propagate a changing avatar Signed-off-by: Nicolas Fella <[email protected]>
github-actions
bot
force-pushed
the
declarative
branch
from
a473a55 to
f586092
Compare
|
AppImage file: Nextcloud-PR-2221-f5860928d9179d31e4226794ecb47af6440b1319-x86_64.AppImage |
er-vin
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using properties and property bindings the QML code gets more declarative rather than imperative, which is considered better.
This patch:
Signed-off-by: Nicolas Fella [email protected]