WebView: Properly handle usernames with spaces and plus signs in it #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path returned from the server encodes a space in the username with `+` and if the username contains a `+` sign it is encoded as `%2B` (cf. https://www.php.net/manual/function.urlencode.php). Fix: Don't (double) decode the URL path and then replace `+` with space (introduced in issue nextcloud#279 resp. commit 9ec61a8). Instead first replace `+` with space, then decode percent encoding. Tested with a username containing a space, a username containing a `+`sign and a username containing just A-Za-z0-9- (with Nextcloud 16). (fixes issue nextcloud#1266) Signed-off-by: Sven Strickroth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path returned from the server encodes a space in the username with
+and if the username contains a+sign it is encoded as%2B(cf. https://www.php.net/manual/function.urlencode.php).Fix: Don't (double) decode the URL path and then replace
+with space (introduced in issue #279 resp. commit 9ec61a8). Instead first replace+with space, then decode percent encoding.Tested with a username containing a space, a username containing a
+sign and a username containing just A-Za-z0-9- (with Nextcloud 16).(fixes issue #1266)