-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a keyring is used (KeepassXC) and is locked, Nextcloud tries to authenticate via browser instead of trying to unlock keyring #3195
Comments
Just for the record: Unlocking works fine with the GNOME keyring. The issue could also be in https://github.com/frankosterfeld/qtkeychain |
I think this is related to/duplicate of #2573 |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
I just came across this and I wanted to know if the merge that closed this issue (keepassxreboot/keepassxc#4443) would solve this issue (on linux), or if the desktop app even honors this? This was just merged a few hours ago, and I dont know if it will be in the next release for keepassxc. |
I just tested with the current develop branch of keepassxc, and it seems to be working now. So we just have to wait for the next release of Keepassxc. If KeePassXC database is locked, and Nextcloud client starts, KeePassXC will show up to ask for unlocking the database. After you unlock it, Nextcloud will authenticate. (NO MORE BROWSER LOGIN REQUEST :) ) One important thing to have this checkbox enabled in KeePassXC I also tested what happens when KeePassXC is not running, and Nextcloud will just wait for some time, and will stop after X seconds passed. |
I just tested this functionality and it doesnt work. I locked databases, exited and relaunched nextcloud. Keepassxc was running. Nextcloud still popped up the browser authentication window. |
Does your Nextcloud stored the credentials in KeepasXC through libsecret? Did you checked in the box that I showed on the picture? For me this is still working. Only thing I noticed since then, that if I don't type in my password for a longer time (maybe minutes), the browser login still pops up. Which is not wanted. |
That is the problem. You have to use the not yet released 2.7 version of KeepasXC as I stated in my original comment. |
I checked and it does work with pre release 2.7.0. Locked keepassxc, launched nextcloud, got the prompt, unlocked and nextcloud started. BTW by default all of those options are checked. |
Is this related to #2573 ? |
Closing per: #3195 (comment) @ericfischerbav It's likely related to some of the people commenting in #2573, yes. |
How to use GitHub
Expected behaviour
Nextcloud Desktop should try to unlock keyring if present (for example Chrome does this succesfully).
Actual behaviour
Nextcloud Desktop starts and opens browser window to authenticate the user.
I have to quit NC, unlock the keepassxc key then start NC again. Then it retrieves the keys from the keychain .
Note that i use libsecret via KeepasXC. It is working as intended when it is unlocked before. NC is started. But if the database is locked, NC fails to signal the keyring that it needs unlocking. For example Chrome, if started with a locked database, signals the keyring and KeepassXC pops up the database unlock message. This behavious should be present in NC too.
I did not test this with the Gnome keychain as i replaced it on all my installations, but it is possible to behave like this (but since Gnome keychain is in most cases permanently unlocked when a user is logged in, this issue doesn't happen).Edit: Gnome keychain unlocking seems to be working as per @FlexW 's comment below.
Steps to reproduce
Client configuration
Client version:
Version 3.2.0 (Debian)
Operating system:
Debial Linux (Testing)
OS language:
English
Qt version used by client package (Linux only, see also Settings dialog):
Not displayed in Settings
Client package (From Nextcloud or distro) (Linux only):
From Nextcloud (also happens with Debian repo versions)
Installation path of client:
/home/username/bin/
Server configuration
Nextcloud version:
Happened with 18-21 (it is not server-related)
Logs
Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.
Since 3.1: Under the "General" settings, you can click on "Create Debug Archive ..." to pick the location of where the desktop client will export the logs and the database to a zip file.
On previous releases: Via the command line:
nextcloud --logdebug --logwindow
ornextcloud --logdebug --logfile log.txt
(See also https://docs.nextcloud.com/desktop/3.0/troubleshooting.html#log-files)
The text was updated successfully, but these errors were encountered: